Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GoToRow timestamp fails when selected row is out of view #1717

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: GoToRow timestamp fails when selected row is out of view #1717

merged 1 commit into from
Jan 8, 2024

Conversation

wusteven815
Copy link
Contributor

@wusteven815 wusteven815 self-assigned this Jan 8, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73e1837) 46.44% compared to head (8895982) 46.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1717   +/-   ##
=======================================
  Coverage   46.44%   46.44%           
=======================================
  Files         611      611           
  Lines       37204    37204           
  Branches     9363     9363           
=======================================
  Hits        17279    17279           
  Misses      19871    19871           
  Partials       54       54
Flag Coverage Δ
unit 46.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wusteven815 wusteven815 changed the title fix(GoToRow): Timestamp fails when row out of view This was referenced 37 minutes ago fix: GoToRow timestamp fails when selected row is out of view Jan 8, 2024
@wusteven815 wusteven815 changed the title This was referenced 37 minutes ago fix: GoToRow timestamp fails when selected row is out of view fix: GoToRow timestamp fails when selected row is out of view Jan 8, 2024
mofojed
mofojed approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mofojed mofojed merged commit 9ddc973 into deephaven:main Jan 8, 2024
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
@wusteven815 wusteven815 deleted the fix-1561 branch January 17, 2024 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mofojed mofojed mofojed approved these changes

Assignees

@wusteven815 wusteven815

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to pick a Timestamp column in the GoToRow dialog if the selected row is out of the viewport
2 participants
@wusteven815 @mofojed